release: v0.20.0

lib/__tests__/urls.test.ts

@@ -18,6 +18,7 @@ import {
   assetExifSummary,
   assetAspectRatio,
   assetCaption,
+  editMarker,
 } from '@/lib/urls';
 
 describe('imageUrl', () => {
@@ -32,6 +33,50 @@ describe('imageUrl', () => {
   });
 });
 
+describe('imageUrl for photos edited in Immich (#831)', () => {
+  const UPDATED = '2026-09-04T19:22:09.220Z';
+
+  it('adds the edit marker only for an edited photo', () => {
+    const marker = Math.floor(Date.parse(UPDATED) / 1000).toString(36);
+    expect(imageUrl({ id: 'id', isEdited: true, updatedAt: UPDATED })).toBe(
+      `/api/image/ENCODED_id?size=preview&e=${marker}`,
+    );
+    expect(imageUrl({ id: 'id', isEdited: true, updatedAt: UPDATED }, 'thumbnail')).toBe(
+      `/api/image/ENCODED_id?size=thumbnail&e=${marker}`,
+    );
+  });
+
+  it('leaves every other URL exactly as before', () => {
+    expect(imageUrl({ id: 'id', isEdited: false, updatedAt: UPDATED })).toBe(
+      '/api/image/ENCODED_id?size=preview',
+    );
+    expect(imageUrl({ id: 'id', updatedAt: UPDATED })).toBe('/api/image/ENCODED_id?size=preview');
+    expect(imageUrl({ id: 'id' })).toBe(imageUrl('id'));
+  });
+
+  it('changes the marker when the photo is edited again', () => {
+    const first = editMarker({ isEdited: true, updatedAt: UPDATED });
+    const again = editMarker({ isEdited: true, updatedAt: '2026-10-01T08:00:00.000Z' });
+    expect(first).toMatch(/^[0-9a-z]{1,16}$/);
+    expect(again).toMatch(/^[0-9a-z]{1,16}$/);
+    expect(again).not.toBe(first);
+  });
+
+  it('reveals the update time to the second only (review of #832)', () => {
+    const marker = editMarker({ isEdited: true, updatedAt: UPDATED });
+    expect(marker).toBe((Date.parse('2026-09-04T19:22:09Z') / 1000).toString(36));
+    expect(editMarker({ isEdited: true, updatedAt: '2026-09-04T19:22:09.999Z' })).toBe(marker);
+    expect(editMarker({ isEdited: true, updatedAt: '2026-09-04T19:22:10.000Z' })).not.toBe(marker);
+  });
+
+  it('still marks an edited photo whose update time is unknown', () => {
+    expect(editMarker({ isEdited: true })).toBe('1');
+    expect(editMarker({ isEdited: true, updatedAt: 'not a date' })).toBe('1');
+    expect(editMarker({ isEdited: false, updatedAt: UPDATED })).toBeNull();
+    expect(editMarker({})).toBeNull();
+  });
+});
+
 describe('exifUrl', () => {
   it('generates an EXIF API URL with encoded token', () => {
     expect(exifUrl('my-asset')).toBe('/api/exif/ENCODED_my-asset');
@@ -144,6 +189,68 @@ describe('assetAspectRatio', () => {
     expect(assetAspectRatio({ exifInfo: undefined })).toBeUndefined();
   });
 
+  /**
+   * #831, measured on Immich 3.2: EXIF keeps describing the stored file after
+   * an edit in Immich, while `width`/`height` follow the edit.
+   */
+  describe('a photo edited in Immich', () => {
+    const exif = (w: number, h: number, orientation: string | null = null) => ({
+      make: null,
+      model: null,
+      lensModel: null,
+      focalLength: null,
+      fNumber: null,
+      exposureTime: null,
+      iso: null,
+      exifImageWidth: w,
+      exifImageHeight: h,
+      orientation,
+      latitude: null,
+      longitude: null,
+      city: null,
+      state: null,
+      country: null,
+      dateTimeOriginal: null,
+      description: null,
+    });
+
+    it('takes a quarter turn from the edited size', () => {
+      // A scan stored 1076×723, rotated 270° in Immich: shown 723×1076.
+      expect(
+        assetAspectRatio({ isEdited: true, width: 723, height: 1076, exifInfo: exif(1076, 723) }),
+      ).toBeCloseTo(723 / 1076);
+    });
+
+    it('takes a crop from the edited size', () => {
+      // Stored 960×1280, cropped to 872×1132.
+      expect(
+        assetAspectRatio({ isEdited: true, width: 872, height: 1132, exifInfo: exif(960, 1280) }),
+      ).toBeCloseTo(872 / 1132);
+      // Stored 8064×6048 with orientation 6 (portrait), cropped to landscape.
+      expect(
+        assetAspectRatio({
+          isEdited: true,
+          width: 6048,
+          height: 4838,
+          exifInfo: exif(8064, 6048, '6'),
+        }),
+      ).toBeCloseTo(6048 / 4838);
+    });
+
+    it('keeps EXIF for a photo that is not edited', () => {
+      expect(
+        assetAspectRatio({ isEdited: false, width: 723, height: 1076, exifInfo: exif(3000, 2000) }),
+      ).toBe(1.5);
+    });
+
+    it('does not fall back to EXIF, which describes the unedited file (review of #832)', () => {
+      expect(assetAspectRatio({ isEdited: true, exifInfo: exif(3000, 2000) })).toBeUndefined();
+      expect(
+        assetAspectRatio({ isEdited: true, width: null, height: 0, exifInfo: exif(3000, 2000) }),
+      ).toBeUndefined();
+    });
+  });
+
   it('returns undefined when height is 0', () => {
     expect(
       assetAspectRatio({