release: v0.12.0 (#520)

Forty-one commits since v0.11.0. See CHANGELOG.md for the full list and the upgrade notes.

app/api/admin/__tests__/status.test.ts

@@ -20,11 +20,21 @@ vi.mock('@/lib/admin/yaml-service', () => ({
   listBackups: vi.fn(async () => []),
 }));
 
+vi.mock('@/lib/config', () => ({
+  getConfig: vi.fn(() => ({
+    needsSetup: false,
+    needsCredentials: false,
+    needsGallery: false,
+  })),
+}));
+
 import { GET } from '../status/route';
 import { readGalleryYaml, readSettingsYaml } from '@/lib/admin/yaml-service';
+import { getConfig } from '@/lib/config';
 
 const mockGallery = readGalleryYaml as unknown as ReturnType<typeof vi.fn>;
 const mockSettings = readSettingsYaml as unknown as ReturnType<typeof vi.fn>;
+const mockConfig = getConfig as unknown as ReturnType<typeof vi.fn>;
 
 async function status() {
   return (await GET()).json();
@@ -35,6 +45,11 @@ describe('GET /api/admin/status — config integrity', () => {
     vi.clearAllMocks();
     mockGallery.mockResolvedValue({ albums: ['a'] });
     mockSettings.mockResolvedValue({ title: 'Site' });
+    mockConfig.mockReturnValue({
+      needsSetup: false,
+      needsCredentials: false,
+      needsGallery: false,
+    });
   });
 
   it('reports a fully configured install as valid', async () => {
@@ -58,10 +73,76 @@ describe('GET /api/admin/status — config integrity', () => {
     expect((await status()).config).toMatchObject({ status: 'invalid', settings: 'invalid' });
   });
 
-  // gallery.yaml, unlike settings.yaml, is genuinely required.
-  it('reports a missing gallery.yaml as invalid', async () => {
+  /**
+   * gallery.yaml, unlike settings.yaml, is genuinely required — but a file that
+   * was never created is a pending setup step, not a corrupt config. Reporting
+   * both as "invalid" told a fresh deployment its config was broken and offered
+   * a backup restore as the cure (#507).
+   */
+  it('reports a missing gallery.yaml as pending setup, not as invalid', async () => {
     mockGallery.mockResolvedValue(null);
 
+    expect((await status()).config).toMatchObject({ status: 'setup', gallery: 'missing' });
+  });
+
+  it('still reports a gallery.yaml that cannot be parsed as invalid', async () => {
+    mockGallery.mockRejectedValue(new Error('bad indentation'));
+
     expect((await status()).config).toMatchObject({ status: 'invalid', gallery: 'invalid' });
   });
 });
+
+describe('GET /api/admin/status — setup state', () => {
+  beforeEach(() => {
+    vi.clearAllMocks();
+    mockGallery.mockResolvedValue({ albums: ['a'] });
+    mockSettings.mockResolvedValue({ title: 'Site' });
+  });
+
+  it('reports a finished install as complete', async () => {
+    mockConfig.mockReturnValue({
+      needsSetup: false,
+      needsCredentials: false,
+      needsGallery: false,
+    });
+
+    expect((await status()).setup).toEqual({
+      complete: true,
+      credentials: 'present',
+      gallery: 'present',
+    });
+  });
+
+  /**
+   * The case from #507: credentials from the environment, no gallery.yaml. The
+   * admin panel must be able to tell those apart to say what is actually left
+   * to do instead of "System Degraded".
+   */
+  it('separates missing credentials from a missing gallery.yaml', async () => {
+    mockConfig.mockReturnValue({
+      needsSetup: true,
+      needsCredentials: false,
+      needsGallery: true,
+    });
+
+    expect((await status()).setup).toEqual({
+      complete: false,
+      credentials: 'present',
+      gallery: 'missing',
+    });
+  });
+
+  it('reports absent credentials', async () => {
+    mockConfig.mockReturnValue({
+      needsSetup: true,
+      needsCredentials: true,
+      needsGallery: true,
+    });
+
+    expect((await status()).setup).toEqual({
+      complete: false,
+      credentials: 'missing',
+      gallery: 'missing',
+    });
+  });
+});